Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored all services code for converting id into UUID #232

Merged
merged 40 commits into from
Nov 22, 2023
Merged

Refactored all services code for converting id into UUID #232

merged 40 commits into from
Nov 22, 2023

Conversation

pallavighule
Copy link
Contributor

What

  • Converting ids into UUID from backend

Why

  • To enhance data security and privacy by making it harder for malicious actors to guess or infer object identifiers.

How

  • Updated schema.prisma for changing auto-incremented id into UUID
  • Updated ledger service APIs
  • Updated ecosystem service APIs
  • Updated organization service APIs
  • Updated user service APIs
  • Updated connection service APIs
  • Updated agent service APIs
  • Updated agent-provisioning service APIs
  • Updated issuance service APIs
  • Updated verification service APIs
  • Updated start_agent shellscript

@pallavighule
refact:converting all orgId userId from number to string in user micr…
e9775c1 
…oservice

Signed-off-by: pallavicoder <pallavi.ghule@ayanworks.com>
@pallavighule
refact:converting all orgId userId from number to string in user micr…
5ed8749 
…oservice

Signed-off-by: pallavicoder <pallavi.ghule@ayanworks.com>
@pallavighule
refact:converting all orgId userId agentId from number to string in a…
3b69da9 
…gent-provisioning microservice

Signed-off-by: pallavicoder <pallavi.ghule@ayanworks.com>
@pallavighule
refact:converting all orgId userId agentId from number to string in a…
1671546 
…gent and agent-provisioning interfaces

Signed-off-by: pallavicoder <pallavi.ghule@ayanworks.com>
@pallavighule
refact:converting all orgId userId agentId from number to string in a…
7a0887b 
…gent micoservice

Signed-off-by: pallavicoder <pallavi.ghule@ayanworks.com>
@pallavighule
refact:converting all orgId userId agentId from number to string in v…
099d06f 
…erification micoservice

Signed-off-by: pallavicoder <pallavi.ghule@ayanworks.com>
@pallavighule
refact:converting all orgId userId agentId from number to string in c…
a8681e4 
…onnection micoservice

Signed-off-by: pallavicoder <pallavi.ghule@ayanworks.com>
@pallavighule
refact:converting all orgId userId agentId from number to string in i…
5d81b24 
…ssuance micoservice

Signed-off-by: pallavicoder <pallavi.ghule@ayanworks.com>
@pallavighule
refact:converting all orgId userId agentId,ledgerId from number to st…
79c77c4 
…ring in Ledger micoservice

Signed-off-by: pallavicoder <pallavi.ghule@ayanworks.com>
@pallavighule
refact:converting all orgId userId agentId,ledgerId ,schemaId from nu…
8e2ada5 
…mber to string in Creddef and Schema micoservice

Signed-off-by: pallavicoder <pallavi.ghule@ayanworks.com>
@pallavighule
refact:converting all orgId userId ,EcosystemId from number to string…
5d596c2 
… in Ecosystem micoservice

Signed-off-by: pallavicoder <pallavi.ghule@ayanworks.com>
@pallavighule
refact:converting all orgId userId ,EcosystemId from number to string…
c91797a 
… in respective dtos

Signed-off-by: pallavicoder <pallavi.ghule@ayanworks.com>
@pallavighule
refact:converting all orgId userId ,EcosystemId from number to string…
762c752 
… in respective Index.js files

Signed-off-by: pallavicoder <pallavi.ghule@ayanworks.com>
@pallavighule
refact:converting all orgId userId ,EcosystemId from number to string…
954235b 
… in respective interfaces files

Signed-off-by: pallavicoder <pallavi.ghule@ayanworks.com>
@pallavighule
refact:enum constant conversion from number to string
bd14c7c 
Signed-off-by: pallavicoder <pallavi.ghule@ayanworks.com>
@pallavighule
refact:Added Port txt file for initial setting of ports
a7cdeba 
Signed-off-by: pallavicoder <pallavi.ghule@ayanworks.com>
@pallavighule
refact:Updated Schema.prisma for convering Ids into UUIDS
9409b2b 
Signed-off-by: pallavicoder <pallavi.ghule@ayanworks.com>
@pallavighule
refact:Updated migrations file
1d7d52b 
Signed-off-by: pallavicoder <pallavi.ghule@ayanworks.com>
@pallavighule
refact:Updated org role service for id to uuid
6531e9b 
Signed-off-by: pallavicoder <pallavi.ghule@ayanworks.com>
@pallavighule
chore:resolved merged conflicts
34e6a8a 
Signed-off-by: pallavicoder <pallavi.ghule@ayanworks.com>
@pallavighule
chore:updated master table entry
01feb52 
Signed-off-by: pallavicoder <pallavi.ghule@ayanworks.com>
@pallavighule
refact:converted ids into string
c0ee156 
Signed-off-by: pallavicoder <pallavi.ghule@ayanworks.com>
@pallavighule
refact:converted id into string
2901c29 
Signed-off-by: pallavicoder <pallavi.ghule@ayanworks.com>
@pallavighule
refact:solved merged conflicts
549ac50 
Signed-off-by: pallavicoder <pallavi.ghule@ayanworks.com>
@pallavighule
chore:resolved merged conflicts
e4d3fda 
Signed-off-by: pallavicoder <pallavi.ghule@ayanworks.com>
@pallavighule pallavighule self-assigned this Nov 6, 2023
pallavighule and others added 2 commits November 7, 2023 10:57
@pallavighule
chore:removed local ip ans added localhost
5fa426b 
Signed-off-by: pallavicoder <pallavi.ghule@ayanworks.com>
conversion id to uudid in master table
53f9423 
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
KulkarniShashank added 13 commits November 10, 2023 18:54
Solved the issue for connectionId in issuance and verification module
e566cdc 
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
refactore the agent-spinup code
7feab49 
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
error handling related agent APIs call
cb5fe87 
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
refactor error messages in httpException
cce94f2 
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
Merge branch 'develop' of https://github.com/credebl/credebl-platform …
82487f1 
…into converting-dbids-into-uuid
Changes on the ecs shell script for agent-spinup
de2b423 
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
Merge branch 'develop' of https://github.com/credebl/credebl-platform …
3ee6f62 
…into converting-dbids-into-uuid
Merge branch 'develop' of https://github.com/credebl/credebl-platform …
8f04b7d 
…into converting-dbids-into-uuid
Added label on the connection in shared agent
bb517ab 
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
Merge branch 'develop' of https://github.com/credebl/credebl-platform …
ab73fcf 
…into converting-dbids-into-uuid
feat: Delete organization and organization wallet
257db74
Merge branch 'develop' of https://github.com/credebl/credebl-platform …
c6d9c21 
…into converting-dbids-into-uuid
Solved the error messages in the issuance
c724290 
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
@sonarqubecloud SonarQubeCloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 58 Code Smells

No Coverage information No Coverage information
19.0% 19.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@KulkarniShashank KulkarniShashank requested review from ajile-in and removed request for ajile-in November 22, 2023 15:33
@nishad-ayanworks
Copy link
Contributor

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 1 Bug Vulnerability A 0 Vulnerabilities Security Hotspot A 0 Security Hotspots Code Smell A 58 Code Smells

No Coverage information No Coverage information 19.0% 19.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Could you please check a bug and try to solve it.

nishad-ayanworks
nishad-ayanworks reviewed Nov 22, 2023
View reviewed changes
Copy link
Contributor

@nishad-ayanworks nishad-ayanworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check sonarcloud comment.

@nishad-ayanworks nishad-ayanworks merged commit 264b879 into develop Nov 22, 2023
2 of 3 checks passed
@nishad-ayanworks nishad-ayanworks deleted the converting-dbids-into-uuid branch December 6, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishad-ayanworks nishad-ayanworks nishad-ayanworks left review comments

@KulkarniShashank KulkarniShashank Awaiting requested review from KulkarniShashank

@ajile-in ajile-in Awaiting requested review from ajile-in

Assignees

@pallavighule pallavighule

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pallavighule @nishad-ayanworks @ajile-in