Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: store schema and credential-definition after submitting transaction #146

Merged
merged 3 commits into from
Oct 12, 2023
Merged

feat: store schema and credential-definition after submitting transaction #146

merged 3 commits into from
Oct 12, 2023

Conversation

tipusinghaw
Copy link
Contributor

What

  • Implemented logic to store schema and credential-definition after submit transaction

@tipusinghaw tipusinghaw self-assigned this Oct 12, 2023
@tipusinghaw tipusinghaw changed the title Endorser request and submit feat: store schema and credential-definition after submit transaction Oct 12, 2023
@tipusinghaw tipusinghaw changed the title feat: store schema and credential-definition after submit transaction feat: store schema and credential-definition after submitting transaction Oct 12, 2023
KulkarniShashank
KulkarniShashank reviewed Oct 12, 2023
View reviewed changes
Copy link
Contributor

@KulkarniShashank KulkarniShashank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts and sonar lint

@tipusinghaw
Merge branch 'develop' of https://github.com/credebl/credebl-platform …
dd98f66 
…into endorser-request-and-submit

Signed-off-by: tipusinghaw <tipu.singh@ayanworks.com>
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

KulkarniShashank
KulkarniShashank approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@KulkarniShashank KulkarniShashank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KulkarniShashank KulkarniShashank merged commit f39337a into develop Oct 12, 2023
2 of 3 checks passed
@KulkarniShashank KulkarniShashank deleted the endorser-request-and-submit branch October 12, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KulkarniShashank KulkarniShashank KulkarniShashank approved these changes

Assignees

@tipusinghaw tipusinghaw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tipusinghaw @KulkarniShashank