Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix react-scripts issue #26

Merged
merged 2 commits into from
Mar 17, 2020
Merged

Fix react-scripts issue #26

merged 2 commits into from
Mar 17, 2020

Conversation

talglobus
Copy link
Contributor

This fixes the issue github.com//issues/23 by updating the version of react-scripts used

dragosct and others added 2 commits February 10, 2020 14:25
@dragosct
Merge pull request creativetimofficial#21 from creativetimofficial/de…
0ed823e 
…v-master

Feature: Update dependencies
@talglobus
Fix react-scripts issue
273642d 
This fixes the issue github.com/creativetimofficial/issues/23 by updating the version of react-scripts used
@einazare einazare self-requested a review March 17, 2020 07:15
einazare
einazare suggested changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@einazare einazare left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • point the PR to the dev-master branch
  • ask for a re-review when changes have been made

@talglobus talglobus changed the base branch from master to dev-master March 17, 2020 10:39
@talglobus talglobus requested a review from einazare March 17, 2020 10:51
@talglobus
Copy link
Contributor Author

@einazare PR branch moved, note that there was another commit by @dragosct10 sitting under it in the commit history

@einazare einazare merged commit 73df994 into creativetimofficial:dev-master Mar 17, 2020
@einazare einazare mentioned this pull request Mar 25, 2020
Closed
@einazare einazare mentioned this pull request May 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@einazare einazare Awaiting requested review from einazare

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@talglobus @einazare @dragosct