-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Margin and Paddign Settings #19
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having the padding panels is already a good move :-) |
Let me know when this is ready for review. |
MuluhGodson
changed the title
Inital theme.json with custom padding settins
Custom Margin and Paddign Settings
Nov 24, 2021
MuluhGodson
requested review from
JackieBinya
and removed request for
a team
November 24, 2021 22:57
brylie
suggested changes
Nov 25, 2021
brylie
approved these changes
Nov 26, 2021
@MuluhGodson, it looks like there is still a minor conflict in functions.php |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes https://github.com/creativecommons/project_creativecommons.org/issues/121 by @brylie
Description
This PR adds padding and margin controls to the
core/columns
block,core/column
block andcore/group
block. Other blocks can easily be added by adding them to thecustom-block-settings.js
file in theenableSpacingControlOnBlocks
array.I used v2 of
theme.json
but this didn't work (unsure why) but since v1 is still supported it can be used in the mean time and subsequently update to v2.Screenshots
Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin