Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTMLGenerator component tests #49

Merged
merged 4 commits into from
Oct 14, 2019
Merged

HTMLGenerator component tests #49

merged 4 commits into from
Oct 14, 2019

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Oct 9, 2019

Fixes #36

Description

Unit and e2e tests for HTMLGenerator component.

Other information

The tests cover filling in 4 out of 6 fields in the form. I couldn't find what filling in Source Work URL and More Permission URL fields change in html or rich text.

Checklist:

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository.
  • My commit messages follow best practices.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Copy link
Member

@akmadian akmadian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the e2e spec to ./test/e2e/specs/components/, and if you would like to remove the Source Work URL and More Permission URL fields from ./src/components/HTMLGenerator.vue, that would also be nice :)

@obulat
Copy link
Contributor Author

obulat commented Oct 13, 2019

I've moved the test files and removed two fields from the HTMLGenerator component.

@akmadian akmadian merged commit 51b47e2 into creativecommons:master Oct 14, 2019
@akmadian
Copy link
Member

Thanks, @obulat!

@obulat obulat deleted the HTMLGeneratorTest branch October 14, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write tests for HTMLGenerator component
2 participants