Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Setting headings' visual styles in an accessible way #320

Merged
merged 3 commits into from
Feb 19, 2021

Conversation

neeraj-2
Copy link
Contributor

Fixes

Fixes #319 by @obulat

Description

It sets the headings' visual styles in an accessible way and thus enhances accessibility.

Screenshots

image

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@neeraj-2 neeraj-2 requested a review from a team as a code owner February 17, 2021 23:05
@neeraj-2 neeraj-2 requested review from obulat and removed request for a team February 17, 2021 23:05
@neeraj-2
Copy link
Contributor Author

@obulat I think there is some problem with testing. I ran the "npm run test" command and got some errors even initially without making any changes.
image

image

@Cronus1007
Copy link
Member

@obulat The tests for #272 which is arising this error.

obulat
obulat previously requested changes Feb 18, 2021
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your great work, @neeraj-2! This PR can be merge after a minor style change is added:
The letter spacing style should be moved from 'Stepper.vue' to 'StepHeader.vue' so that the letters in the headings are not spaced out too wide:

.step-header__title.b-header {
letter-spacing: normal;
}

@obulat
Copy link
Contributor

obulat commented Feb 18, 2021

@obulat I think there is some problem with testing. I ran the "npm run test" command and got some errors even initially without making any changes.
image

Actually, this was my mistake: this logic should be tested in integration tests, not the unit tests as it is now. Can you please delete the failing test?

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thank you.

This test will be later added to the integration test suite.
@zackkrida zackkrida dismissed obulat’s stale review February 19, 2021 23:44

Requested changes have been made

@zackkrida zackkrida merged commit 770d313 into creativecommons:master Feb 19, 2021
@neeraj-2
Copy link
Contributor Author

Great work! Thank you.

Thanks, @zackkrida, and @obulat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility: heading elements should be in a sequentially-descending order
4 participants