Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark your work section #243

Merged
merged 8 commits into from
Dec 8, 2020
Merged

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Dec 5, 2020

Fixes

Fixes #219 by @panchovm
Fixes #225 by @obulat

Description

This PR updates Mark Your Work Section to match v2 mockups:

  • Uses Vocabulary Tabs and Boxed Tabs for License Code
  • Adds the ability to choose Short/Full license name
  • Adds a tab for downloading XMP meta data (which is not yet implemented)
  • Fixes links to work and creator's profile to open in a new window
  • Updates the language ('Mark' instead of 'License')

Screenshots

image

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested a review from a team as a code owner December 5, 2020 19:51
@obulat obulat requested review from akmadian and removed request for a team December 5, 2020 19:51
@obulat obulat changed the title License use card Mark your work section Dec 6, 2020
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@zackkrida zackkrida merged commit 4df6242 into creativecommons:master Dec 8, 2020
@obulat obulat deleted the license_use_card branch January 10, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Vocabulary Tabs component Update the Mark your work section
2 participants