Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copy button in plain text tab under "Use your license" #235

Merged
merged 3 commits into from
Nov 28, 2020

Conversation

ObjectBoxPC
Copy link
Contributor

Fixes

Fixes #206 by @panchovm

Description

This fixes the copy button in the plain text tab under "Use your license" so it will actually copy the text.

Technical details

The cause seemed to be the duplicate IDs between the two different tabs. This pull request creates separate IDs for the text elements. In addition, some other duplicate IDs were converted to classes.

This code seems like it could use an overhaul to make the tabs more flexible. The current code relies on a lot of assumptions (like there being only two tabs, Web and print, with the Web tab having two sub-tabs under it).

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@ObjectBoxPC ObjectBoxPC requested a review from a team as a code owner November 28, 2020 05:42
@ObjectBoxPC ObjectBoxPC requested review from obulat and removed request for a team November 28, 2020 05:42
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your change works great, thank you for your contribution, @ObjectBoxPC !

@obulat obulat merged commit 1eac9c2 into creativecommons:master Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy action is not working in plain text tab
2 participants