Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vue Vocabulary to latest version #230

Merged
merged 4 commits into from
Dec 2, 2020

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Nov 25, 2020

Fixes

Related to #229 by @obulat

Description

This PR updates the Vocabulary version to the most recent one. It also imports it and registers the Vue Vocabulary components in main.js so that they can be used throughout the app without importing individual components. The import path is set to the file itself for now, before the PR solving the path issue is merged into Vue Vocabulary.

Buefy version is also updated to fix an error caused by a breaking change.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Buefy is also updated to fix import error
@obulat obulat requested a review from a team as a code owner November 25, 2020 09:46
@obulat obulat requested review from akmadian, kgodey and zackkrida and removed request for a team November 25, 2020 09:46
@obulat obulat merged commit 587cf23 into creativecommons:master Dec 2, 2020
@obulat obulat deleted the vocabulary_update branch December 2, 2020 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants