Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added unit test for LicenseDropdown component #201

Merged
merged 3 commits into from
Nov 4, 2020

Conversation

codetheorem
Copy link
Contributor

Signed-off-by: Hrishikesh Agarwal hrishikeshagarwalv@gmail.com

Fixes

Fixes #120 by @akmadian

Description

Added unit test for component LicenseDropdown.vue

Technical details

Added snapshot test for the component.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Signed-off-by: Hrishikesh Agarwal <hrishikeshagarwalv@gmail.com>
@codetheorem codetheorem requested a review from a team as a code owner November 2, 2020 20:00
@codetheorem codetheorem requested review from obulat and removed request for a team November 2, 2020 20:00
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start, @codetheorem ! We should also test that selecting an option emits the corresponding event.

Signed-off-by: Hrishikesh Agarwal <hrishikeshagarwalv@gmail.com>
@codetheorem codetheorem requested a review from obulat November 3, 2020 16:27
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed the test setup a little bit so that we can test that the selected license is committed to the store, and removed i18n setup which is unnecessary for this component.
Thank you for your work!

@obulat obulat merged commit b64474a into creativecommons:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unit and e2e tests for the LicenseDropdown component
2 participants