Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license-utilities tests + update attrToFull to act like attrToShort #136

Merged
merged 2 commits into from
Mar 15, 2020
Merged

Conversation

acagastya
Copy link
Contributor

Fixes #125

Description

I have added various tests, I think 126 in total.

Other information

I have also updated license-utilities for an edge case:attrToFull({BY: undefined}) acts similar to attrToShort({BY: undefined})

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository.
  • My commit messages follow best practices.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@acagastya acagastya requested review from a team March 14, 2020 19:28
Copy link
Member

@akmadian akmadian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Ok that's a lot of tests! I'm happy that the tests are so stringent, it'll be good to have confidence that it's extremely unlikely that anything will get past them, but it's definitely almost too much. I think the amount of tests could easily be cut by 50 or 75%, and we would still be ok.

I'm gonna merge anyways since I think it's good to ere on the side of too many tests for this file since so much critical functionality is based on these utils.

Thanks for working on this :)

@akmadian akmadian merged commit 3533fbe into creativecommons:master Mar 15, 2020
@acagastya
Copy link
Contributor Author

You are welcome, @akmadian.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unit tests for license-uitilities.js
2 participants