Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected Dublin Core Terms namespace #134

Merged
merged 1 commit into from
Mar 28, 2020
Merged

Corrected Dublin Core Terms namespace #134

merged 1 commit into from
Mar 28, 2020

Conversation

Bobulous
Copy link
Contributor

Modified namespace prefix from "dc" to "dct" within the span element for the title, to match the xmlns:dct declaration for the Dublin Core Terms namespace.

Description

Unless I'm misunderstanding the intent of the code, the span element for the title is trying to refer to the Dublin Core Terms "title" property, in which case I believe it should be referring to the "dct" namespace prefix declared within one of its ancestor elements.

Other information

The same thing is seen in LicenseCode.vue and I'll request a pull for a patch of that file too. (Apologies, I don't know how to get both changes included in the same patch using the web UI editing tool.)

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository.
  • My commit messages follow best practices.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Modified namespace prefix from "dc" to "dct" within the span element for the title, to match the xmlns:dct declaration for the Dublin Core Terms namespace.
@Bobulous Bobulous requested review from a team March 13, 2020 15:56
@akmadian akmadian requested a review from obulat March 13, 2020 18:13
@akmadian
Copy link
Member

I'm gonna request a review from @obulat since she wrote this code :)

@Bobulous, in the future, please remember to open an issue proposing changes before submitting a PR with said changes! For more information, check out CC's Code Contribution Guidelines

@Bobulous
Copy link
Contributor Author

Sorry, @akmadian, I couldn't find a recipe for proper submission of minor fixes. I'll raise an issue first in future, then refer to it from any related pull requests I create.

Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, @Bobulous ! See comment in PR#135.

@obulat obulat merged commit 5609a5f into creativecommons:master Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants