Change instances of "cc-chooser" to "chooser", other cleanup and small fixes

[akmadian]

Fixes #128

Description

The repo was renamed from "cc-chooser" to "chooser". This PR updates various strings to reflect that change.

There are also some piggyback fixes that were preventing the site from building. These include:

• Linting fixes
• A broken component usage, this required some follow up styling fixes

Other information

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the master branch of the repository.
• My commit messages follow best practices.
• I added tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no
  visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[akmadian]

Sorry about all the funky review requests, github seems to be automatically adding and removing some requests :/

[obulat]

Ari, did you run eslint on the repo?

I have changed the linter settings from vue/essential to vue/recommended in .eslintrc.js, and when I run npm run-script lint from Webstorm (actually, it runs it automatically when I click a green triangle next to lint line in 'package.json'), all the additional new lines are inserted.
I haven't tried running the linter from Visual Studio Code, it might behave differently (it does so with regards to line endings).

I was thinking that automatic linting could be added to github action so that the code in the repo is consistent, and code review is simplified. However, if you think it makes the code unnecessarily long, or makes writing the code unnecessarily difficult, maybe it would be better to restore the linter settings to vue\essential in the '.eslintrc.js'. Otherwise, every time I click on lint in Webstorm, all extra newlines are inserted again, and all component files look as if they were edited.

[akmadian]

Yep, there were linting errors causing build to fail. I think it's a good idea to add a lint workflow, one for testing, one for linting, one for build maybe? Maybe on each push would be good.

[obulat]

Yep, there were linting errors causing build to fail. I think it's a good idea to add a lint workflow, one for testing, one for linting, one for build maybe? Maybe on each push would be good.

I didn't realize that there were two linting changes: one in 'Cleanup' commit and one in 'Linting fixes' commit, and thought that the change in 'Cleanup' (removing extra new lines) was the final one. So, if I understand correctly now, 'Linting fixes' applied the 'vue/recommended' standard to the whole repo, and this makes the code look consistent and applies recommended Vue.js code style.

I can look into the workflows.

[akmadian]

@obulat Yep, that's correct. Sounds good re workflows :)

[obulat]

I edited LicenseIcons css only looking at this component, so I added margin-left of 3px to the icons so that they are not too close to the license name in RichText code. Now I see LicenseIcons are used in the HelpSection as well, so because the left margin is local to LicenseCode component, it would be better to add styling here, so that the styling in other components is not affected.

.license-text .photo-license-icons {
    height: 1.4rem!important;
    **margin-left: 3px;**
}

[obulat]

Looks and works great.
Only a 3px styling change is needed, I think :)