Merge pull request #13 from neeraj-2/master

Fetched changes from master branch
creativecommons · Feb 20, 2021 · 64a68e6 · 64a68e6
2 parents cf3cc79 + 365bc05
commit 64a68e6
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 17 deletions.
diff --git a/src/App.vue b/src/App.vue
@@ -20,9 +20,9 @@
                 </ul>
             </nav>
 
-            <h2>
+            <h1 class="title is-2">
                 {{ $t('chooser.heading') }}
-            </h2>
+            </h1>
             <p class="stepper-instructions body-bigger">
                 {{ $t('chooser.instructions') }}
             </p>

diff --git a/src/components/FooterSection.vue b/src/components/FooterSection.vue
@@ -166,7 +166,9 @@
                 </div>
                 <div class="column">
                     <section class="donate-section">
-                        <h5>{{ $t('footer.donation.header') }} </h5>
+                        <h2 class="title is-5">
+                            {{ $t('footer.donation.header') }}
+                        </h2>
                         <p>{{ $t('footer.donation.call') }}</p>
                         <a
                             class="button small donate"

diff --git a/src/components/HelpSection.vue b/src/components/HelpSection.vue
@@ -1,8 +1,8 @@
 <template>
     <div class="help-section">
-        <h3>
+        <h2 class="title is-3">
             {{ $t('help.heading') }}
-        </h3>
+        </h2>
         <ul class="help-links">
             <li
                 v-for="(modal, idx) in modals"

diff --git a/src/components/StepHeader.vue b/src/components/StepHeader.vue
@@ -5,9 +5,9 @@
         @click="activate"
         @keyup.13="activate"
     >
-        <h5 class="step-header__title b-header">
+        <h2 class="step-header__title b-header title is-5">
             {{ $t(stepHeaderText) }}
-        </h5>
+        </h2>
         <div
             v-if="step.status === 'completed'"
             class="step-header__caption"
@@ -92,6 +92,9 @@ export default {
     }
 
 }
+.step-header__title.b-header {
+        letter-spacing: normal;
+}
 .step-header__title {
     margin-bottom: 0.25rem;
 }

diff --git a/src/components/Stepper.vue b/src/components/Stepper.vue
@@ -309,9 +309,6 @@ export default {
         background: #d8d8d8;
         color: #333333;
     }
-    .step-header__title.b-header {
-        letter-spacing: normal;
-    }
     .slide-fade-enter-active {
         transition: translate .5s ease, opacity 0.3s ease-in;
     }

diff --git a/tests/unit/specs/components/App.spec.js b/tests/unit/specs/components/App.spec.js
@@ -6,7 +6,6 @@ import Vocabulary from '@creativecommons/vue-vocabulary/vue-vocabulary.common'
 import VueScrollTo from 'vue-scrollto'
 import createStore from '@/store'
 import App from '@/App'
-import Stepper from '@/components/Stepper'
 
 describe('App.vue', () => {
     let wrapper
@@ -50,10 +49,4 @@ describe('App.vue', () => {
         await wrapper.vm.$store.commit('setSelected', { name: 'BY', selected: false })
         expect(rightColumn.find('licensedetailscard-stub').exists()).toBe(true)
     })
-
-    it('Check that showLicenseUse returns true if currentStepId is equal to 7', async() => {
-        expect(wrapper.find('licenseusecard-stub').exists()).toBe(false)
-        await wrapper.findComponent(Stepper).vm.$emit('input', 7)
-        expect(wrapper.find('licenseusecard-stub').exists()).toBe(true)
-    })
 })