Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compound text string ist difficult to translate #13

Closed
pixolin opened this issue Feb 22, 2022 · 4 comments · Fixed by #14
Closed

Compound text string ist difficult to translate #13

pixolin opened this issue Feb 22, 2022 · 4 comments · Fixed by #14
Labels
bug Something isn't working

Comments

@pixolin
Copy link
Contributor

pixolin commented Feb 22, 2022

File src/add-button.js uses in line 40 a compound text string which is difficult to translate.

To avoid a difference in formal and informal German, the best translation would be "{post_type} hinzufügen".

Currently the button uses a compound of "Add new" (Erstellen) and Posttype. "Erstellen Seite" and "Seite Erstellen" are both gramatically wrong; the first sounds odd, the second has an incorrect capital "E".

Providing a text string where just the post type is replaced would make it easier to translate: %s hinzufügen (as translation for Add new %s) would fit to the typical wording in WordPress.

@aurooba
Copy link
Member

aurooba commented Feb 22, 2022

Interesting! So what I'm hearing is that when the term 'add new' is paired with a noun, it often takes a different form than when it is used alone. I didn't know that! That's really good to know.

@pixolin
Copy link
Contributor Author

pixolin commented Feb 22, 2022

It seems we are using a word out of context here to create a compound. No idea where the translation "Erstellen" (literally "Create") comes from actually as it isn't part of the plugin translation.
I'm afraid, my skills are too limited here to be of much help. However replacing a compound with text out of context with a new string seems to be a pragmatic approach.

@aurooba aurooba added the bug Something isn't working label Feb 22, 2022
@aurooba
Copy link
Member

aurooba commented Feb 22, 2022

That's okay! I just want to fully understand. the "Erstellen" is part of core WordPress translation. When I switch my WordPress installation to German, I see that term for 'Add New' in the Dashboard. That's where the plugin is also picking it up from.
Screen Shot 2022-02-22 at 11 34 06 AM

So then, my follow up question is: is this wrong in WordPress Core?

@aurooba
Copy link
Member

aurooba commented Feb 22, 2022

I want to note that I think your PR is great, and I can use that to then address/fix why the 'Duplicate' is not getting translated too. But before we make any changes, I just want to fully understand what's going on so that I can do better in the future. :)

aurooba added a commit that referenced this issue Mar 5, 2022
Fixes #13 – Makes compound string easier to translate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants