Allow to use integer literals #19
Conversation
as defined in go1.13 and later
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
=======================================
Coverage 98.26% 98.26%
=======================================
Files 2 2
Lines 115 115
=======================================
Hits 113 113
Misses 1 1
Partials 1 1
Continue to review full report at Codecov.
|
defaults.go
Outdated
| autoBase = 0 | ||
|
|
||
| bitSize8 = 8 | ||
| bitSize16 = 16 | ||
| bitSize32 = 32 | ||
| bitSize64 = 64 |
There was a problem hiding this comment.
I don't really see the point in defining these constants...
There was a problem hiding this comment.
i agree with bitXXSize constants , but autoBase add context to 0 value in base but it is not so significant therefore I will change that
defaults.go
Outdated
| @@ -58,57 +65,57 @@ func setField(field reflect.Value, defaultVal string) error { | |||
| field.Set(reflect.ValueOf(val).Convert(field.Type())) | |||
| } | |||
| case reflect.Int: | |||
| if val, err := strconv.ParseInt(defaultVal, 10, 64); err == nil { | |||
| if val, err := strconv.ParseInt(defaultVal, autoBase, strconv.IntSize); err == nil { | |||
| @@ -1,5 +1,5 @@ | |||
| language: go | |||
| go: 1.11 | |||
| go: 1.13 | |||
There was a problem hiding this comment.
Note to self:
"This PR require at least go1.13"
Per the number literal proposal, Go 1.13 supports a more uniform and modernized set of number literal prefixes.
As says in strconv.ParseInt documentation:
"If the base argument is 0, the true base is implied by the string's prefix: 2 for "0b", 8 for "0" or "0o", 16 for "0x", and 10 otherwise. Also, for argument base 0 only, underscore characters are permitted as defined by the Go syntax for integer literals. "
This allow to use hexadecimal , octal or binary to define integer default values. With this PR is posible to use other notations accord its context without break current behaviour for integers.
Examples:
Breaking changes
This PR require at least go1.13
Fixed
Potential error in 32 bit systems because int and uint are assumed as 64 bit long