fix pest 2.x tests

creagia · Apr 4, 2024 · f526446 · f526446
1 parent 54e585a
commit f526446
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 7 deletions.
diff --git a/tests/NotificationTest.php b/tests/NotificationTest.php
@@ -4,6 +4,8 @@
 use Creagia\LaravelRedsys\Events\RedsysNotificationEvent;
 use Creagia\LaravelRedsys\Events\RedsysSuccessfulEvent;
 use Creagia\LaravelRedsys\Events\RedsysUnsuccessfulEvent;
+use Creagia\LaravelRedsys\RequestBuilder;
+use Creagia\LaravelRedsys\Tests\Models\TestModel;
 use Creagia\Redsys\Exceptions\InvalidRedsysResponseException;
 use Illuminate\Support\Facades\Event;
 
@@ -24,7 +26,7 @@
     post(action(RedsysNotificationController::class), ['Ds_MerchantParameters' => '']);
 })->throws(InvalidRedsysResponseException::class);
 
-it('saves notification attempt to database', function ($testModel, $redsysRequestBuilder) {
+it('saves notification attempt to database', function (TestModel $testModel, RequestBuilder $redsysRequestBuilder) {
     $redirectResponse = $redsysRequestBuilder->redirect();
 
     $fakeGateway = new \Creagia\Redsys\RedsysFakeGateway(
@@ -39,7 +41,7 @@
     ]);
 })->with('payment');
 
-it('changes Redsys payment status to paid', function ($testModel, $redsysRequestBuilder) {
+it('changes Redsys payment status to paid', function (TestModel $testModel, RequestBuilder $redsysRequestBuilder) {
     $redirectResponse = $redsysRequestBuilder->redirect();
     $request = $redsysRequestBuilder->request;
 
@@ -54,7 +56,7 @@
     expect($request->status)->toBe(\Creagia\LaravelRedsys\RedsysRequestStatus::Paid->value);
 })->with('payment');
 
-it('changes Redsys payment status to denied', function ($testModel, $redsysRequestBuilder) {
+it('changes Redsys payment status to denied', function (TestModel $testModel, RequestBuilder $redsysRequestBuilder) {
     $redirectResponse = $redsysRequestBuilder->redirect();
     $request = $redsysRequestBuilder->request;
 
@@ -69,7 +71,7 @@
     expect($request->status)->toBe(\Creagia\LaravelRedsys\RedsysRequestStatus::Denied->value);
 })->with('payment');
 
-it('executes payable model paid method', function ($testModel, $redsysRequestBuilder) {
+it('executes payable model paid method', function (TestModel $testModel, RequestBuilder $redsysRequestBuilder) {
     $redirectResponse = $redsysRequestBuilder->redirect();
     $request = $redsysRequestBuilder->request;
 

diff --git a/tests/PayableTest.php b/tests/PayableTest.php
@@ -5,7 +5,7 @@
 use Creagia\LaravelRedsys\RequestBuilder;
 use Creagia\LaravelRedsys\Tests\Models\TestModel;
 
-it('can return total amount', function (TestModel $testModel) {
+it('can return total amount', function (TestModel $testModel, RequestBuilder $requestBuilder) {
     expect($testModel->getTotalAmount())->toEqual(12345);
 })->with('payment');
 

diff --git a/tests/RedirectTest.php b/tests/RedirectTest.php
@@ -11,7 +11,7 @@
 
 use function Pest\Laravel\withoutExceptionHandling;
 
-it('can redirect to Redsys', function ($testModel, RequestBuilder $redsysRequestBuilder) {
+it('can redirect to Redsys', function (TestModel $testModel, RequestBuilder $redsysRequestBuilder) {
     withoutExceptionHandling();
     $redirectResponse = $redsysRequestBuilder->redirect();
     expect($redirectResponse->content())->toContain('realizarPago');

diff --git a/tests/StandalonePaymentTest.php b/tests/StandalonePaymentTest.php
@@ -16,4 +16,4 @@
         )
     );
     expect($redsysRequest->redirect()->content())->toContain('realizarPago');
-})->with('payment');
+});