Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #167 to avoid race on Linux. #177

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Revert #167 to avoid race on Linux. #177

merged 1 commit into from
Nov 16, 2023

Conversation

creack
Copy link
Owner

@creack creack commented Nov 9, 2023

cc @sio I am reverting the nonblock PR, it causes a race on Linux, randomly blocking on read/write and randomly failing to set/get size.

Adding -count=100 to the test consistently reproduces the issue. Using .Fd() fixes the issue.

I would rather keep your changes and avoid .Fd(), but it would need to work consistently, if you have any idea, let me know.

cc @kr if you have any ideas too.

@creack creack merged commit 3194d69 into master Nov 16, 2023
5 checks passed
@creack creack deleted the revert-nonblock-ioctl branch November 16, 2023 15:21
renovate bot referenced this pull request in kairos-io/provider-kairos Dec 13, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/creack/pty](https://togithub.com/creack/pty) | require |
patch | `v1.1.20` -> `v1.1.21` |

---

### Release Notes

<details>
<summary>creack/pty (github.com/creack/pty)</summary>

### [`v1.1.21`](https://togithub.com/creack/pty/releases/tag/v1.1.21)

[Compare
Source](https://togithub.com/creack/pty/compare/v1.1.20...v1.1.21)

#### What's Changed

- Tests cleanup by [@&#8203;creack](https://togithub.com/creack) in
[https://github.com/creack/pty/pull/173](https://togithub.com/creack/pty/pull/173)
- Revert [#&#8203;167](https://togithub.com/creack/pty/issues/167) to
avoid race on Linux. by [@&#8203;creack](https://togithub.com/creack) in
[https://github.com/creack/pty/pull/177](https://togithub.com/creack/pty/pull/177)

**Full Changelog**:
creack/pty@v1.1.20...v1.1.21

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 11pm every weekday,before 7am
every weekday,every weekend" in timezone Europe/Brussels, Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/kairos-io/provider-kairos).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot referenced this pull request in kairos-io/provider-kairos Aug 14, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/creack/pty](https://togithub.com/creack/pty) | `v1.1.21`
-> `v1.1.23` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fcreack%2fpty/v1.1.23?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fcreack%2fpty/v1.1.23?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fcreack%2fpty/v1.1.21/v1.1.23?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fcreack%2fpty/v1.1.21/v1.1.23?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>creack/pty (github.com/creack/pty)</summary>

### [`v1.1.23`](https://togithub.com/creack/pty/releases/tag/v1.1.23)

[Compare
Source](https://togithub.com/creack/pty/compare/v1.1.21...v1.1.23)

#### What's Changed

- Upgrade to go version 1.18.2 to fix multiple CVEs by
[@&#8203;pinaki124](https://togithub.com/pinaki124) in
[https://github.com/creack/pty/pull/154](https://togithub.com/creack/pty/pull/154)
- Tests cleanup by [@&#8203;creack](https://togithub.com/creack) in
[https://github.com/creack/pty/pull/173](https://togithub.com/creack/pty/pull/173)
- Revert [#&#8203;167](https://togithub.com/creack/pty/issues/167) to
avoid race on Linux. by [@&#8203;creack](https://togithub.com/creack) in
[https://github.com/creack/pty/pull/177](https://togithub.com/creack/pty/pull/177)
- Add non-blocking notes by
[@&#8203;WeidiDeng](https://togithub.com/WeidiDeng) in
[https://github.com/creack/pty/pull/180](https://togithub.com/creack/pty/pull/180)
- ztypes_openbsd\_32bit_int.go: remove arch list by
[@&#8203;n2vi](https://togithub.com/n2vi) in
[https://github.com/creack/pty/pull/189](https://togithub.com/creack/pty/pull/189)

#### New Contributors

- [@&#8203;pinaki124](https://togithub.com/pinaki124) made their first
contribution in
[https://github.com/creack/pty/pull/154](https://togithub.com/creack/pty/pull/154)
- [@&#8203;WeidiDeng](https://togithub.com/WeidiDeng) made their first
contribution in
[https://github.com/creack/pty/pull/180](https://togithub.com/creack/pty/pull/180)
- [@&#8203;n2vi](https://togithub.com/n2vi) made their first
contribution in
[https://github.com/creack/pty/pull/189](https://togithub.com/creack/pty/pull/189)

**Full Changelog**:
creack/pty@v1.1.20...v1.1.23

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 11pm every weekday,before 7am
every weekday,every weekend" in timezone Europe/Brussels, Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/kairos-io/provider-kairos).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant