-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore : Update CRC GitHub issue template to be more interactive (#4494) #4495
chore : Update CRC GitHub issue template to be more interactive (#4494) #4495
Conversation
id: actual-behavior | ||
attributes: | ||
label: Actual behavior | ||
description: A clear and concise description of what actually happen. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: happens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing, I copy pasted this template from Eclipse JKube.
.github/ISSUE_TEMPLATE/config.yml
Outdated
blank_issues_enabled: true | ||
contact_links: | ||
- name: CRC IRC Community Chat (suitable for short, simple casual discussions) | ||
url: https://freenode.net/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the right URL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just used the same URL as provided in https://github.com/crc-org/crc?tab=readme-ov-file#community
I can change it to any other URL decided by the team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I mean the channel name is #codeready
so there should be a clear direction to use that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't we move this to liberachat?
However nobody from the team is watching this channel as far as I know, so I'm not sure it is useful to mention it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cfergeau : Shall I remove this list element?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 with Rohan. I think we can remove this field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can always re-add after we made a decision in regard to #4506
5c03342
to
0cf8f14
Compare
CRC project is using quite old style issue template. Update it to be more interactive so that users can provide information easily. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
0cf8f14
to
23a7d28
Compare
Looks good to me! |
@rohanKanojia: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gbraad The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Fixes: #4494
Relates to: #4494
CRC project is using quite old style issue template. Update it to be more interactive so that users can provide information easily.
You can check the preview of how it would look like here .
I've only ported relevant fields that were present in old template. If you think something else needs to be added, please add a comment on the pull request.
Type of change
test, version modification, documentation, etc.)
Proposed changes
Update GitHub Issue template to use new issue template format.
Testing
I've tested the template on my github fork. You can try it out here.
Contribution Checklist