Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup for show method #176

Merged

Conversation

christophermark
Copy link
Contributor

Following up from my comment in #125.

This simplifies the public interface for showing the splash screen with a custom theme:

// Show with a custom theme
SplashScreen.show(this, R.style.SplashScreenTheme);

// Show with the default theme
SplashScreen.show(this);
// or alternatively
SplashScreen.show(this, false);

// Show with the default fullscreen theme
SplashScreen.show(this, true);

As a secondary request, could you push a new release version after merge?
After #125 was merged, there is no release containing the new fixes.

Concerns are now more separated for the SplashScreen#show methods.
@crazycodeboy crazycodeboy merged commit 909fd73 into crazycodeboy:master May 21, 2018
@christophermark christophermark deleted the theming-code-cleanup branch June 4, 2018 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants