Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go 1.21.8 1.22.1 #70

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Go 1.21.8 1.22.1 #70

merged 1 commit into from
Mar 14, 2024

Conversation

Fabio1988
Copy link
Contributor

@Fabio1988 Fabio1988 commented Mar 14, 2024

I am still not sure how related those two repos are 😄
What I understood this repo contains the images.

crazy-max/xgo#123

@Fabio1988 Fabio1988 requested a review from crazy-max as a code owner March 14, 2024 08:58
@crazy-max
Copy link
Owner

I am still not sure how related those two repos are 😄

xgo depends on goxx so needs first goxx update before creating a PR on xgo

Copy link
Owner

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment and also squash your commits, thanks!

.github/workflows/build.yml Outdated Show resolved Hide resolved
@Fabio1988
Copy link
Contributor Author

See my comment and also squash your commits, thanks!

Thanks a lot, squashed and fixed :)

Copy link
Owner

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check other places where this should be bumped to 1.21.8 similar to #68, thx

.github/workflows/build.yml Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@Fabio1988 Fabio1988 changed the title Go 1.22.1 Go 1.21.8 1.22.1 Mar 14, 2024
Copy link
Owner

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align commit message as well to Go 1.21.8 1.22.1

@Fabio1988
Copy link
Contributor Author

Fabio1988 commented Mar 14, 2024

Align commit message as well to Go 1.21.8 1.22.1

same thought at same time,done 😄
Thanks for your patience :)

Copy link
Owner

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@crazy-max crazy-max merged commit bfa2e4a into crazy-max:main Mar 14, 2024
23 checks passed
@Fabio1988 Fabio1988 deleted the patch-1 branch March 14, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants