Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: allow hash in color codes #172

Closed

Conversation

davorpa
Copy link

@davorpa davorpa commented Sep 7, 2022

Resolves #153

@davorpa davorpa requested a review from crazy-max as a code owner September 7, 2022 06:14
Copy link
Owner

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase

@davorpa davorpa force-pushed the feature/allow-hash-in-color-codes branch from feb8afa to 9b78520 Compare October 24, 2022 19:02
@davorpa davorpa requested a review from crazy-max October 24, 2022 19:02
@crazy-max
Copy link
Owner

CI doesn't look happy about it 😅

@davorpa
Copy link
Author

davorpa commented Oct 26, 2022

CI doesn't look happy about it 😅

What I need to run test on my machine? I'm running Windows and it seems that some config is missing (e.g. GITHUB_TOKEN) when I run docker buildx bake validate or yarn test even running over a clean master branch

Copy link
Owner

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI doesn't look happy about it 😅

What I need to run test on my machine? I'm running Windows and it seems that some config is missing (e.g. GITHUB_TOKEN) when I run docker buildx bake validate or yarn test even running over a clean master branch

Sorry for the delay, #192 removes requirement for the github token. You can now just run docker buildx bake test or yarn test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow hash in color codes
2 participants