Added as simple callback with the filter object so it can be dynamically changed #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SGTM, can you add a basic test please? Thx! |
sure. added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed that the implementation of the ipfilter middleware, while very useful, lacks the option to dynamically control the filter object. This is a desirable functionality that enables a running service to blacklist a network address based on whatever logic (for example, using some IP blocklist).
I added a simple mechanism for the caller to get hold of the filter object after it is created. Then, the underlying implementation allows for changing it during runtime.
I hope you'll find it useful to add to your implementation.
Cheers,
Shmul