Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sort_tags #655

Merged
merged 3 commits into from
Jul 22, 2022
Merged

Fix sort_tags #655

merged 3 commits into from
Jul 22, 2022

Conversation

hatamiarash7
Copy link
Contributor

We don't have numerical for sort tags type. It should be semver

@hatamiarash7 hatamiarash7 requested a review from crazy-max as a code owner July 22, 2022 08:08
@crazy-max
Copy link
Owner

Good catch, can you also update docs for other providers please?

@hatamiarash7
Copy link
Contributor Author

Good catch, can you also update docs for other providers please?

Done 👍

hatamiarash7
hatamiarash7 commented Jul 22, 2022
View reviewed changes
Copy link
Contributor Author

@hatamiarash7 hatamiarash7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

crazy-max
crazy-max approved these changes Jul 22, 2022
View reviewed changes
Copy link
Owner

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@crazy-max crazy-max merged commit 387ee68 into crazy-max:master Jul 22, 2022
@hatamiarash7 hatamiarash7 deleted the patch-1 branch July 22, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazy-max crazy-max crazy-max approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hatamiarash7 @crazy-max