Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for Managed Identities #36 #68

Merged
merged 5 commits into from
Mar 28, 2022
Merged

Added support for Managed Identities #36 #68

merged 5 commits into from
Mar 28, 2022

Conversation

janegilring
Copy link
Contributor

@janegilring janegilring commented Mar 18, 2022 •
edited
Loading

Lets discuss this PR on the next SIG Terraform - Azure Maintainer Forum.

Specifically, is it possible to mark the identity_ids property as optional, so that it does not need to be specified with a null value:

identity = {
    type = "SystemAssigned"
    identity_ids = null
  }

Roberth Strand and others added 4 commits March 28, 2022 15:17
@janegilring
Update ext_adds.tf
cc320c0 
Signed-off-by: Jan Egil Ring <jan.egil.ring@outlook.com>
@janegilring
Added support for Managed Identities #36
dabe020 
Signed-off-by: Jan Egil Ring <jan.egil.ring@outlook.com>
@janegilring
Merge branch 'dev/managed_identities' of github.com:crayon/terraform-…
7bda356 
…azurerm-vm into dev/managed_identities
@janegilring
terraform fmt
9cc1e23 
Signed-off-by: Jan Egil Ring <jan.egil.ring@outlook.com>
@janegilring janegilring merged commit 995b146 into main Mar 28, 2022
@janegilring janegilring deleted the dev/managed_identities branch March 28, 2022 13:28
@janegilring janegilring linked an issue Apr 4, 2022 that may be closed by this pull request
Add support for Managed Identities #36
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthstrand roberthstrand roberthstrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
SIG Terraform
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Managed Identities
2 participants
@janegilring @roberthstrand