Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for missing geospatial datatypes to SQLAlchemy dialect #360

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Add support for missing geospatial datatypes to SQLAlchemy dialect #360

merged 1 commit into from
Jul 23, 2020
+168 −2

Conversation

autophagy
Copy link
Contributor

@autophagy autophagy commented Jul 10, 2020 •
edited
Loading

This should address crate/sqlalchemy-cratedb#118

@autophagy autophagy force-pushed the mika/missing-types branch from 2dec032 to 9b3ba7f Compare July 10, 2020 14:54
@autophagy autophagy changed the title Add support for missing datatypes to SQLAlchemy dialect Add support for missing geospatial datatypes to SQLAlchemy dialect Jul 14, 2020
@autophagy autophagy marked this pull request as ready for review July 14, 2020 08:43
@autophagy autophagy requested review from a team and MarkusH July 14, 2020 08:43
nomicode
nomicode reviewed Jul 14, 2020
View reviewed changes
docs/sqlalchemy.rst Outdated Show resolved Hide resolved
nomicode
nomicode reviewed Jul 14, 2020
View reviewed changes
docs/sqlalchemy.rst Outdated Show resolved Hide resolved
nomicode
nomicode reviewed Jul 14, 2020
View reviewed changes
docs/sqlalchemy.rst Outdated Show resolved Hide resolved
nomicode
nomicode reviewed Jul 14, 2020
View reviewed changes
Copy link
Contributor

@nomicode nomicode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. left some minor comments/suggestions

MarkusH
MarkusH reviewed Jul 15, 2020
View reviewed changes
Copy link
Contributor

@MarkusH MarkusH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, overall. Left a few notes, nothing major. 💯

docs/sqlalchemy.rst Outdated Show resolved Hide resolved
src/crate/client/sqlalchemy/types.py Outdated Show resolved Hide resolved
src/crate/client/sqlalchemy/types.py Outdated Show resolved Hide resolved
src/crate/client/sqlalchemy/types.py Outdated Show resolved Hide resolved
docs/sqlalchemy.rst Outdated Show resolved Hide resolved
src/crate/client/doctests/sqlalchemy.txt Outdated Show resolved Hide resolved
src/crate/client/doctests/sqlalchemy.txt Outdated Show resolved Hide resolved
@autophagy
Copy link
Contributor Author

@MarkusH I've pushed up a commit that should hopefully address your comments!

MarkusH
MarkusH approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@MarkusH MarkusH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: 🚀

@autophagy autophagy force-pushed the mika/missing-types branch from 383e66e to 87c2e5a Compare July 23, 2020 11:28
@autophagy autophagy merged commit 1f3189e into master Jul 23, 2020
@autophagy autophagy deleted the mika/missing-types branch July 23, 2020 11:58
@amotl amotl mentioned this pull request Dec 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkusH MarkusH MarkusH approved these changes

@nomicode nomicode nomicode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@autophagy @nomicode @MarkusH