Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference to "All Features" page to primary navigation #547

Closed
wants to merge 1 commit into from

Conversation

amotl
Copy link
Member

@amotl amotl commented Nov 13, 2024

About

@kneth signalled interest to increase awareness about the All Features page.
This patch intends to add a reference to the primary navigation prominently.

Preview

https://crate-docs-theme--547.org.readthedocs.build/en/547/

image

@cla-bot cla-bot bot added the cla-signed label Nov 13, 2024
@amotl amotl requested a review from kneth November 13, 2024 21:44
@amotl amotl marked this pull request as ready for review November 13, 2024 21:44
@msbt
Copy link
Collaborator

msbt commented Nov 14, 2024

@amotl I must say, I'm not a fan of that solution, in the suggested patch it will look like this if I click on "Features", right?

image

Can't we move the whole thing (including subpages) into the root nav to avoid duplicate current highlights? IMO Features don't fit in the guide & tutorials category anyways, just my 2 cents ;)

@kneth
Copy link

kneth commented Nov 14, 2024

move the whole thing

I agree. Having the same tree twice isn't optimal.

@amotl amotl closed this Nov 14, 2024
@amotl amotl deleted the amo/navigation-add-features branch November 14, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants