-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix building docs at crate/crate
by removing stray README.md
#539
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Evaluation
For some reason, this informative README.md made it into the documentation tree and was picked up by Sphinx. That is clearly not intended, and we don't know why it (suddenly!?) happens on the blackbox setup of crate/crate.
Solution
Let's try to fix that problem by just renaming this file to README.txt
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why should the rename fix it?
Shouldn't it be deleted instead? Does it adds value to keep it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The renaming should fix it, because Sphinx will not pick it up to be rendered from Markdown into HTML. By the way, I dont't actually know why it is being picked up now, but renaming it without much ado appeared to be the most easy fix for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather delete this file, I see no reason why it should stay inside the repo.
Sure, we can add the information inside to README or docs/something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@BaurzhanSakhariev reported:
🤷 |
ccb7582
to
14e2f52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather delete this file, I see no reason why it should stay inside the repo.
14e2f52
to
b9f728b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Problem
@BaurzhanSakhariev just reported:
Does it look familiar to anyone?