fix(config)!: Turn off release with package.publish = false

Fixes #399
crate-ci · Oct 14, 2022 · b35b462 · b35b462
1 parent 18f5866
commit b35b462
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/docs/reference.md b/docs/reference.md
@@ -84,9 +84,12 @@ Workspace configuration is read from the following (in precedence order)
 | `target`       | \-              | string                      | \-           | Target triple to use for the verification build |
 | `dependent-version` | \-         | `upgrade`, `fix`, `error`, `warn`, `ignore` | `fix`      | Policy for upgrading path dependency versions within the workspace |
 
-
 Note: fields are from the package-configuration unless otherwise specified.
 
+Note:
+[`package.publish`](https://doc.rust-lang.org/cargo/reference/manifest.html#the-publish-field)
+is interpreted the same as `release = false`
+
 ### Supported Environment Variables
 
 * `PUBLISH_GRACE_SLEEP`: sleep timeout between crates publish when releasing from workspace. This is a workaround to make previous crate discoverable on crates.io.

diff --git a/src/config.rs b/src/config.rs
@@ -468,6 +468,7 @@ pub fn load_package_config(
         .and_then(|f| f.as_bool())
         .unwrap_or(true)
     {
+        release_config.release = Some(false);
         release_config.publish = Some(false);
     }