Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-check fails on workspaces due to --no-default-features #66

Closed
qdot opened this issue Oct 19, 2019 · 4 comments · Fixed by #72
Closed

cargo-check fails on workspaces due to --no-default-features #66

qdot opened this issue Oct 19, 2019 · 4 comments · Fixed by #72

Comments

@qdot
Copy link

qdot commented Oct 19, 2019

--no-default-features errors on workspace projects, meaning the cargo-check step will fail for any workspace project. It'd be nice to have a parameter to turn this build check off.

See rust-lang/cargo#5015
qdot added a commit to qdot/azure-pipelines that referenced this issue Oct 19, 2019
@qdot
Add param to turn off no-default-features builds on workspaces crate-…
b1f8872 
…ci#66

Leaves --no-default-features step to build by default, but allows
turning it off for workspaces.

Fixes crate-ci#66
qdot added a commit to qdot/azure-pipelines that referenced this issue Oct 19, 2019
@qdot
Add param to turn off no-default-features builds on workspaces crate-…
916b1d9 
…ci#66

Leaves --no-default-features step to build by default, but allows
turning it off for workspaces.

Fixes crate-ci#66
@jonhoo
Copy link
Collaborator

jonhoo commented Oct 19, 2019

@epage I think more and more that we need either a workspace flag, or a separate workspace stage :'(

@qdot
Copy link
Author

qdot commented Oct 19, 2019

I submitted a small workaround PR for now. It could be used for configuring a workspace stage if you do go that direction.

@epage
Copy link
Contributor

epage commented Oct 20, 2019

@epage I think more and more that we need either a workspace flag, or a separate workspace stage :'(

Are all crates safe with "no-default-features`? Would we need it configurable anyways, like all-features?

qdot added a commit to qdot/azure-pipelines that referenced this issue Nov 21, 2019
@qdot
Add param to turn off no-default-features builds on workspaces crate-…
00e02a1 
…ci#66

Leaves --no-default-features step to build by default, but allows
turning it off for workspaces.

Fixes crate-ci#66
@jonhoo
Copy link
Collaborator

jonhoo commented Dec 22, 2019

See also rust-lang/cargo#7727

jonhoo added a commit that referenced this issue Dec 22, 2019
@jonhoo
Disable --no-default-features on workspace crates
404c6cc 
Fixes #66.
@jonhoo jonhoo mentioned this issue Dec 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable --no-default-features on workspace crates crate-ci/azure-pipelines
3 participants
@qdot @epage @jonhoo