Merge pull request #9 from craigpotter/add-php8.4-support

Feature | PHP 8.4 Support (Tests)
craigpotter · Dec 17, 2024 · f994cd0 · f994cd0
2 parents 982d184 + fe8059a
commit f994cd0
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -18,7 +18,7 @@ jobs:
       fail-fast: true
       matrix:
         os: [ ubuntu-latest, windows-latest ]
-        php: [ 8.1, 8.2 ]
+        php: [ 8.1, 8.2, 8.3, 8.4 ]
         stability: [ prefer-lowest, prefer-stable ]
 
     name: P${{ matrix.php }} - ${{ matrix.stability }} - ${{ matrix.os }}

diff --git a/src/Fca.php b/src/Fca.php
@@ -4,9 +4,9 @@
 
 namespace CraigPotter\Fca;
 
-use Saloon\Http\Connector;
 use Saloon\Http\Request;
 use Saloon\Http\Response;
+use Saloon\Http\Connector;
 use Saloon\PaginationPlugin\Paginator;
 use CraigPotter\Fca\Requests\GetEndpoint;
 use CraigPotter\Fca\Resources\FirmResource;

diff --git a/src/Resources/FirmResource.php b/src/Resources/FirmResource.php
@@ -4,8 +4,8 @@
 
 namespace CraigPotter\Fca\Resources;
 
-use Saloon\Http\Connector;
 use Saloon\Http\Response;
+use Saloon\Http\Connector;
 use Saloon\PaginationPlugin\PagedPaginator;
 use Saloon\Exceptions\Request\RequestException;
 use CraigPotter\Fca\Requests\Firm\GetFirmDetails;
@@ -30,7 +30,7 @@ public function exists(): bool
         try {
             $response = $this->connector->send(new GetFirmDetails($this->frn));
         } catch (RequestException $e) {
-            if(str_contains($e->getMessage(), 'Firm not found')) {
+            if (str_contains($e->getMessage(), 'Firm not found')) {
                 return false;
             }
 

diff --git a/tests/Feature/FirmResourceTest.php b/tests/Feature/FirmResourceTest.php
@@ -3,8 +3,8 @@
 declare(strict_types=1);
 
 use CraigPotter\Fca\Fca;
-use Saloon\Http\Faking\MockClient;
 use Saloon\Http\PendingRequest;
+use Saloon\Http\Faking\MockClient;
 use Saloon\Http\Faking\MockResponse;
 use CraigPotter\Fca\DataObjects\Address;
 use CraigPotter\Fca\DataObjects\Individual;