Fix Invert(ref Matrix3x2) #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* erroneous results were given by matrix fields being altered sequentially, some fields would use new state instead of the input * Check for matrix.Determinant() = 0, now returns the identity instead of det becoming infinite"
There was a problem hiding this comment.
Thanks @Eb3yr
Would it be possible to add a unit test for this change before merging?
|
Added a test for two matrices with a positive and negative determinant, and for a matrix with a determinant of zero. |
AristurtleDev
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously Matrix3x2 sequentially mutated the fields of the input ref matrix, so later elements would be computed from modified elements. Fixed by constructing and assigning a new struct to the input matrix.
Additionally added a check for the determinant equalling zero, which would set the reciprocal multiplier to infinity. Returns the Identity matrix in this case, as MM⁻¹=I for non-singular matrices. M⁻¹=I in the singular case would uphold this.
Resolves issue #960