fix(verify-otp): content type for otp is not correct

verify otp accepts application/x-www-form-urlencoded craftsys/msg91-laravel#5
craftsys · Oct 20, 2020 · b767e3a · b767e3a
1 parent e69fb02
commit b767e3a
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/src/OTP/VerifyRequest.php b/src/OTP/VerifyRequest.php
@@ -8,4 +8,6 @@
 class VerifyRequest extends Request
 {
     protected $url = URLs::OTP_VERIFY_URL;
+
+    protected $content_type = \GuzzleHttp\RequestOptions::FORM_PARAMS;
 }
diff --git a/src/Support/Request.php b/src/Support/Request.php
@@ -6,6 +6,7 @@
 use Craftsys\Msg91\Exceptions\ValidationException;
 use Craftsys\Msg91\Contracts\Options;
 use GuzzleHttp\Client as GuzzleHttpClient;
+use GuzzleHttp\RequestOptions;
 
 abstract class Request
 {
@@ -36,13 +37,19 @@ abstract class Request
      */
     protected $url = "";
 
+    /**
+     * Content type
+     */
+    protected $content_type = RequestOptions::JSON;
+
     /**
      * Validation instance
      *
      * @var \Craftsys\Msg91\Requests\Validator
      */
     protected $validator;
 
+
     /**
      * Create a new request instance
      *
@@ -93,10 +100,9 @@ public function handle()
         $method = strtolower($this->method);
         try {
             $resp = $client->{$method}($this->url, [
-                \GuzzleHttp\RequestOptions::JSON => $payload,
+                $this->content_type => $payload,
                 "headers" => [
                     'authkey' => $payload['authkey'],
-                    'content-type' => 'application/json'
                 ]
             ]);
             return new Response($resp);

diff --git a/tests/OTP/OTPServiceTest.php b/tests/OTP/OTPServiceTest.php
@@ -84,7 +84,7 @@ public function test_verify_otp()
         // check the method
         $this->assertEquals("POST", $transaction['request']->getMethod());
         // check the request data
-        $data = (array) json_decode($transaction['request']->getBody()->getContents());
+        parse_str($transaction['request']->getBody()->getContents(), $data);
         $this->assertArrayHasKey('mobile', $data);
         $this->assertEquals($phone_number, $data['mobile']);
         $this->assertArrayHasKey('authkey', $data);