Fix for #84 - Remove old version attachments while publishing. #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganapativs
changed the title
|
Sorry been away for a while I will take a look at this as seems to be a common issue, it was originally done as I was basing things off HTTP sniffing and I thought attachments were needed. Looks like it is not and sorts the issue with JSON files getting to large. |
|
Cool, will the attachment key be removed from stored JSON anytime soon? |
|
Spending some time this weekend to get this project back into shape @ganapativs sorry it is taking so long 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Fix for #84
How did you implement it:
Remove old version attachments to prevent index.json size growth, Only keep latest version attachment for future use.
How can we verify it:
Just publish update to a package, you should see size on index.json is reduced.
Todos:
ready for revieworwipIs this a breaking change?: NO/YES