Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing Serverless version to greater than #83

Merged
merged 1 commit into from
Jul 4, 2017

Conversation

ryanmurakami
Copy link
Contributor

What did you implement:

Changed the required Serverless version to greater than instead of equals.

I was trying to use codebox with the newest version of serverless (1.13.2) and got the version error. I thought this change would make it easier to maintain codebox going forward.

How did you implement it:

How can we verify it:

View serverless.yml or deploy codebox-npm with a new version of serverless.

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Tag ready for review or wip

Is this a breaking change?: NO

@hassankhan
Copy link
Contributor

Another potential way of doing this could be to have a npm run deploy script which calls a locally-installed version of Serverless (from npm i -D serverless to do any deploys.

That way we can keep the Serverless version locked down in the package.json instead of in serverless.yml (where it kind of feels out-of-place IMO).

@jonsharratt jonsharratt merged commit f09ff0b into craftship:master Jul 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants