Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for removing a site from an entry #7190

Closed
JeanLucEsser opened this issue Nov 26, 2020 · 6 comments
Closed

Allow for removing a site from an entry #7190

JeanLucEsser opened this issue Nov 26, 2020 · 6 comments
Labels
enhancement improvements to existing features internationalization 🌐 features related to internationalization or localization
Milestone

Comments

@JeanLucEsser
Copy link

JeanLucEsser commented Nov 26, 2020

Description

I have logged an enhancement ticket to multisite here : #7189

But I think the premise of my ticket could be considered a bug, or at least an incongruity as you cannot undo or cancel something you may have done and change your mind afterwards. It's a one way ticket. Let me explain:

When the channel propagation method is to let each entry choose which site it should be saved to, we get a button to add a site in our entry form, but once added, we get no way to remove a site, only a way to deactivate, which is not the same.

If we are able to explicitly add a site to the entry so it can be activated / deactivated, we should be able to remove a site from the entry so that the entry is not listed anymore as a site element.

You can add a new Site to an Entry:
image

But once added, you cannot remove it, only disable it:
image

@brandonkelly brandonkelly added enhancement improvements to existing features internationalization 🌐 features related to internationalization or localization and removed bug labels Dec 9, 2020
@brandonkelly
Copy link
Member

It’s currently working as intended, so not a bug.

I didn’t add the ability to remove a site because I’m worried it will be too easily misunderstood, and authors will end up unintentionally deleting content.

Perhaps I can add an option alongside “Delete entry” in the Save menu dropdown, for deleting the entry for the currently selected site.

brandonkelly added a commit that referenced this issue Dec 9, 2020
@brandonkelly
Copy link
Member

brandonkelly commented Dec 9, 2020

Alright, this is added for Craft 3.6. Going forward, if both of these are true:

  • you are editing an entry within a section whose propagation method is set to “Let each entry choose which sites it should be saved to”
  • the entry exists for at least two sites

…and one of the following are true:

…then the Save button will have a new “Delete [draft/entry] for this site” option:

The Save button menu in Craft 3.6, for a draft, which shows the new “Delete draft for this site” option

Upon clicking it, you will be redirected back to the entry/draft in another site that is still active, or back to the Entries index if you didn’t have permission to access any of the other sites.

@brandonkelly brandonkelly added this to the 3.6 milestone Dec 9, 2020
@JeanLucEsser
Copy link
Author

Thanx for this Brandon.

You’re so quick I haven’t had time to share my own proposition for this ;)

Give me a few hours to see what you did here and compare it to what I was about to share as a solution. But it looks like you nailed it as always.

Just trying to see what you mean by « enabled » for at least 2 sites. Do you mean published (why then?) or existing (obvious)? And I was thinking about relocating the add site to the action bar. Let me finish thinking this through and getting back to you.

And again, as always, this is some unbelievable great work you’re doing.

@brandonkelly
Copy link
Member

Sorry for the confusion… I meant that the entry exists for at least two sites; it doesn’t have to be enabled for them though. (It would be awkward to have the “Delete entry for this site” option on a single-site entry.)

@brandonkelly
Copy link
Member

Craft 3.6 RC2 is out now with this change.

@brandonkelly
Copy link
Member

Craft 3.6 has now been officially released ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improvements to existing features internationalization 🌐 features related to internationalization or localization
Projects
None yet
Development

No branches or pull requests

2 participants