-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor Python 3 compatibility fixes #98
Conversation
Unfortunately tests fail even on the master branch in both Python 2 and 3 (without any modifications on my part) so it's hard to tell if this minor change will cause any trouble (though I seriously doubt it). EDIT: Perhaps adding Travis to this repo would be sweet? 🎉 |
Python 2.7 is the oldest version that has cmp_to_key. I think that should be okay, right? |
Hey, thanks for this. There are a few other places where a comparison function is being used. Do you want to put
Yes, requiring 2.7 is fine.
This will happen sometime. |
@carlthome now that |
Conflicts: pretty_midi/pretty_midi.py
Great news, @craffel! Rebased and merged with current master. 👍 I'm unable to find any other places using |
Oops, sorry, I misunderstood - thought the issue was whenever |
Minor compatibility issue with pm.write() fixed.
Thus
channels
does not have a remove method in a Python 3 environment. This pull request fixes that by explicitly makingchannels
into a list.