Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update README #290

Merged
merged 2 commits into from
May 27, 2024
Merged

chore: update README #290

merged 2 commits into from
May 27, 2024

Conversation

lucasfernog-crabnebula
Copy link
Member

No description provided.

Copy link

netlify bot commented May 27, 2024

Deploy Preview for cn-devtools-app canceled.

Name Link
🔨 Latest commit b95a18c
🔍 Latest deploy log https://app.netlify.com/sites/cn-devtools-app/deploys/66545fe788f2810008d121dc

Copy link
Contributor

@johann-crabnebula johann-crabnebula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to confirm that following the docs for v1 works just fine!

When trying the flow for v2 I am running into a problem.

TLDR

The readme is not compatible with version 0.1.0 of the plugin, which is currently installed when you run cargo add tauri-plugin-devtools

When will we bump the version @lucasfernog-crabnebula ?

Version 0.1.0 is missing the ::init function.

When I run:

cargo add tauri-plugin-devtools

I get the following:

    Updating crates.io index
      Adding tauri-plugin-devtools v0.1.0 to dependencies.

So installed plugin version is v0.1.0.

The following error occurs when trying to run the application:

error[E0425]: cannot find function `init` in crate `tauri_plugin_devtools`
  --> src/main.rs:12:43
   |
12 |     let devtools = tauri_plugin_devtools::init();
   |                                           ^^^^ not found in `tauri_plugin_devtools`

Screenshot 2024-05-27 at 16 32 40 (2)

@lucasfernog-crabnebula
Copy link
Member Author

oh sorry i missed the version specifier that is required until we stable release

Copy link
Contributor

@johann-crabnebula johann-crabnebula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retested and approved.

@johann-crabnebula johann-crabnebula merged commit 250c8b1 into main May 27, 2024
5 checks passed
@johann-crabnebula johann-crabnebula deleted the chore/update-readme branch May 27, 2024 10:30
This was referenced May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants