Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS-36682 Replaced Moshi with Jackson #375

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Conversation

DreierF
Copy link
Contributor

@DreierF DreierF commented Nov 30, 2023

Addresses issue TS-36682

  • Changes are tested adequately
  • Agent's README.md updated in case of user-visible changes
  • CHANGELOG.md updated
  • Present new features in N&N
  • TGA Tutorial updated
  • TIA Tutorial updated

Please respect the vote of the Teamscale bot or flag irrelevant findings as tolerated or false positives. If you feel that the Teamscale config needs adjustment, please state so in a comment and discuss this with your reviewer.

@DreierF DreierF force-pushed the ts/36682_remove_moshi branch from 3ccc398 to 790df3f Compare November 30, 2023 16:33
Copy link
Contributor

@snowbagoly snowbagoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Just one question (and we should probably update the architecture in Teamscale 😁 ).

public double score;

/**
* Field for storing the tests rank. The rank is the 1-based index of the test
* in the prioritized list.
*/
@Json(name = "rank")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You deleted this one, but kept the one on the PrioritizableTest - is there any difference? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, just overlooked it for PrioritizableTest. Removed it there as well

@DreierF DreierF force-pushed the ts/36682_remove_moshi branch from 790df3f to b153a1d Compare December 1, 2023 14:08
@snowbagoly snowbagoly merged commit 7ff0e08 into master Dec 1, 2023
4 of 5 checks passed
@snowbagoly snowbagoly deleted the ts/36682_remove_moshi branch December 1, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants