Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#607: hidden identifier work and framework for future match warning work #671

Conversation

echicoine-icf
Copy link
Contributor

This work encompasses the ongoing development of methodology for maintaining a list of exact matches, case insensitive matches, and lays ground work for future "sounds like" matches.

@@ -3,6 +3,36 @@
"annotation" : [ {
"translatorOptions" : "",
"type" : "CqlToElmInfo"
}, {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file ended up being the perfect test for the hidden identifier work

@brynrhodes brynrhodes self-requested a review November 22, 2021 20:07
@JPercival JPercival self-requested a review July 7, 2022 15:01
Copy link
Contributor

@JPercival JPercival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR now has conflicts. Can you resolve those?

@echicoine-icf echicoine-icf requested review from JPercival and removed request for brynrhodes August 24, 2022 14:48
@JPercival JPercival requested review from brynrhodes and removed request for JPercival August 29, 2022 17:00
@echicoine-icf echicoine-icf requested review from JPercival and removed request for brynrhodes November 21, 2022 16:02
@echicoine-icf
Copy link
Contributor Author

This PR now has conflicts. Can you resolve those?

Conflicts should be resolved currently.

@JPercival
Copy link
Contributor

JPercival commented Jun 2, 2023

I do understand the need for the hiddenIdentifier work here, but I don't understand the use case for "sounds like" matches in a compiler. Would you mind elaborating on that?

@JPercival
Copy link
Contributor

Closed in favor of #1277

@JPercival JPercival closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants