Fixing up tests from the published spec #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Formatting check succeeded! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1346 +/- ##
============================================
- Coverage 63.17% 63.16% -0.01%
+ Complexity 6132 6131 -1
============================================
Files 468 468
Lines 25360 25360
Branches 4720 4720
============================================
- Hits 16020 16019 -1
- Misses 7183 7184 +1
Partials 2157 2157 ☔ View full report in Codecov by Sentry. |
JPercival
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncing the test suite content with what is published in the spec, there were several tests in the published spec that were not included, as well as several that we have the wrong expected outcome for (based on my best impersonation of a compliant CQL evaluation engine). I've also submitted several issues to track the issues with the tests that I've added to the skip list as part of this PR.