-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update javax to jakarta namespaces #1236
Update javax to jakarta namespaces #1236
Conversation
Notify @vitorpamplona when this gets released. |
I think we'll need to more cleanly separate out the JAXB dependencies, in particular with respect to the There has been some effort to make JAXB optional to support Android, and perhaps we need to push that further. Downstream from CQL neither Android nor HAPI ought to depend on JAXB, and CQL should factored such that that is a possibility. I actually thought we were further along that path. I'm surprised to see how many changes were required to update the jakarta dependencies. I'm going to check out this branch and play with it a bit to see if we can't further separate it. Will report back! |
Contrary to what I stated previously, we should take these changes and we can take them now. The rest of this comment explains why I think that. Two other alternatives were considered:
Why I changed my mind:
In summary, the impact of this change is less than I expected while the alternatives were more costly than I expected. Thoughts or concerns @brynrhodes @jamesagnew @vitorpamplona ? |
Agree. The impact should be small.
Keep in mind, Google/Android/IntelliJ have been pushing for Kotlin Serialization instead of Jackson. We might need to have a third option down the road. But that will change everything. |
No description provided.