Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for R4SubmitDataService and tweak docs for class itself. #605

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

lukedegruchy
Copy link
Contributor

  • Write new test
  • Tweak javadocs

Closes: #601

Copy link

github-actions bot commented Dec 2, 2024

Formatting check succeeded!

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.91%. Comparing base (83da84e) to head (0e16393).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #605      +/-   ##
============================================
+ Coverage     73.81%   73.91%   +0.09%     
  Complexity       19       19              
============================================
  Files           361      361              
  Lines         18974    18974              
  Branches       2532     2532              
============================================
+ Hits          14006    14024      +18     
+ Misses         3611     3591      -20     
- Partials       1357     1359       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@barhodes barhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the unused argument and TODO note about it should get SonarQube passing.

@lukedegruchy lukedegruchy enabled auto-merge (squash) December 3, 2024 15:51
Copy link

sonarqubecloud bot commented Dec 3, 2024

@lukedegruchy lukedegruchy merged commit c8a3ea2 into master Dec 3, 2024
9 checks passed
@lukedegruchy lukedegruchy deleted the 601-submit-data-testing branch December 3, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Submit Data Operation Testing Coverage
2 participants