Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace String period start and end with ZonedDateTime and add new validator for ZonedDateTime periods. #538

Merged
merged 21 commits into from
Oct 3, 2024

Conversation

lukedegruchy
Copy link
Contributor

@lukedegruchy lukedegruchy commented Oct 1, 2024

  • Take nullable ZonedDateTimes for all period start and ends where before evaluate measures took strings
  • Add new validator to ensure period start and ends make sense vis-a-vis each others
  • Adjust tests
  • Add new test for validator

Closes #528

…idation class for single and multi measure evaluation. Ensure all existing tests pass. No new tests yet.
Copy link

github-actions bot commented Oct 1, 2024

Formatting check succeeded!

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 92.72727% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.59%. Comparing base (21fceaa) to head (361147e).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...s/cqf/fhir/cr/measure/common/MeasureEvaluator.java 90.90% 1 Missing and 1 partial ⚠️
...fhir/cr/measure/common/MeasurePeriodValidator.java 90.00% 0 Missing and 1 partial ⚠️
...cds/cqf/fhir/cr/measure/r4/R4MeasureProcessor.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #538      +/-   ##
============================================
+ Coverage     72.56%   72.59%   +0.03%     
  Complexity       19       19              
============================================
  Files           361      362       +1     
  Lines         18562    18597      +35     
  Branches       2869     2874       +5     
============================================
+ Hits          13469    13501      +32     
- Misses         3733     3734       +1     
- Partials       1360     1362       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukedegruchy lukedegruchy changed the title Replace String period start and end with ZonedDateTime. Add a new va… Replace String period start and end with ZonedDateTime and add new validator for ZonedDateTime periods. Oct 1, 2024
@lukedegruchy lukedegruchy marked this pull request as ready for review October 1, 2024 21:35
Copy link

sonarqubecloud bot commented Oct 3, 2024

@Capt-Mac Capt-Mac enabled auto-merge (squash) October 3, 2024 20:55
@Capt-Mac Capt-Mac merged commit e808abe into master Oct 3, 2024
6 checks passed
@Capt-Mac Capt-Mac deleted the ld-20240913-client-timezone-for-measurement-period-3 branch October 3, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure measurement periods respect configured timezone or UTC default
2 participants