Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Population Measure crashes when subjectIds is null or empty #358

Closed
vitorpamplona opened this issue Oct 10, 2023 · 0 comments · Fixed by #359
Closed

Population Measure crashes when subjectIds is null or empty #358

vitorpamplona opened this issue Oct 10, 2023 · 0 comments · Fixed by #359

Comments

@vitorpamplona
Copy link
Contributor

if subjectIds is null or empty, it crashes the app.

Keep in mind that orElse evaluates even if its object is filled. subjectIds.get(0) == null should probably be the last expression in this if.

clinical-reasoning/cqf-fhir-cr/src/main/java/org/opencds/cqf/fhir/cr/measure/r4/R4MeasureProcessor.java

Line 88 in 0fe8e3a

subjectIds.get(0) == null || subjectIds == null || subjectIds.isEmpty()

Same happens in R5
@vitorpamplona vitorpamplona mentioned this issue Oct 11, 2023
Merged
25 tasks
vitorpamplona added a commit to vitorpamplona/clinical-reasoning that referenced this issue Oct 11, 2023
@vitorpamplona
Fixes cqframework#358
fe5505b
@vitorpamplona vitorpamplona mentioned this issue Oct 11, 2023
Merged
JPercival pushed a commit that referenced this issue Oct 16, 2023
@vitorpamplona
Fixes crash on measure evaluate when subjectIds is null (#359)
9790135 
Fixes #358
barhodes added a commit that referenced this issue Oct 30, 2023
@barhodes
Squashed commit of the following:
5ef7c00 
commit af2db9a
Author: mdnazmulkarim <nazmul.karim@smilecdr.com>
Date:   Fri Oct 27 10:25:08 2023 -0600

    snapshot 3.0.0-PRE-10 (#371)

commit 0ff4f32
Author: JP <jonathan.percival@smilecdr.com>
Date:   Thu Oct 26 13:15:54 2023 -0600

    Update versions and fix build / test publication (#370)

commit b235356
Author: JP <jonathan.percival@smilecdr.com>
Date:   Fri Oct 20 10:42:06 2023 -0600

    Feature use new java extension (#364)

    * Swap to Java Platform Support extension for VS Code

    * Fix up pom

    * pom clean-up

    * Fix warnings

    * Fix formatting

    * Update java version and distribution

    * Add maven cache

    * Add implicit flag for benchmarks

commit 9790135
Author: Vitor Pamplona <vitor@vitorpamplona.com>
Date:   Mon Oct 16 15:35:08 2023 -0400

    Fixes crash on measure evaluate when subjectIds is null (#359)

    Fixes #358

commit 5b5414e
Author: Justin McKelvy <60718638+Capt-Mac@users.noreply.github.com>
Date:   Thu Oct 12 09:53:00 2023 -0600

    isolate getsubjects method in Measure Processor (#361)

    spotless apply

commit 0fe8e3a
Author: Jonathan Percival <jonathan.i.percival@gmail.com>
Date:   Thu Oct 5 14:36:08 2023 -0600

    Rev to PRE9 Snapshot

commit 4b799ca
Author: Jonathan Percival <jonathan.i.percival@gmail.com>
Date:   Thu Oct 5 13:28:25 2023 -0600

    --amend

commit d3f7b09
Author: Jonathan Percival <jonathan.i.percival@gmail.com>
Date:   Thu Oct 5 13:16:37 2023 -0600

    Rev to release version

commit 8057c70
Author: Justin McKelvy <60718638+Capt-Mac@users.noreply.github.com>
Date:   Wed Oct 4 10:32:11 2023 -0600

    Measure service subject reporttype bugs (#354)

    * fix reportType null bug, add subject & practitioner referenc to MR, practitionerGroup paramter, reporter param

    * add measureService tests for r4

    * spotless apply fixes

    * copy reportType setting from r4 to Dstu3 processor

    * revert defaulting logic for reportType, add check for null item in list for default reportType

    * remove commented out code, spotless apply edits

    ---------

    Co-authored-by: JP <jonathan.percival@smilecdr.com>

commit ad744bd
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Oct 4 10:27:14 2023 -0600

    Bump pillow from 9.4.0 to 10.0.1 in /docs/src/doc (#355)

    Bumps [pillow](https://github.com/python-pillow/Pillow) from 9.4.0 to 10.0.1.
    - [Release notes](https://github.com/python-pillow/Pillow/releases)
    - [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst)
    - [Commits](python-pillow/Pillow@9.4.0...10.0.1)

    ---
    updated-dependencies:
    - dependency-name: pillow
      dependency-type: direct:production
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 87434a4
Author: Jonathan Percival <jonathan.i.percival@gmail.com>
Date:   Mon Oct 2 22:15:46 2023 -0600

    More performance tweaks

commit 85e8933
Author: Jason Evans <jason.a.evans@gmail.com>
Date:   Mon Oct 2 21:50:01 2023 -0600

    KA issue 32 - optimize CQL for Lantana (#352)

    * Update GlycemicControlHypoglycemicInitialPopulation.cql

    * SupplementalDataElements changes

    * MATGlobalCommonFunctions R4 changes

    * MATGlobalCommonFunctions R3 changes

    * MATGlobalCommonFunctions QICore R4 changes

    * Fixes / optimizations

    * Revert non-CaseRepresentation content

    * Restore additional content

    ---------

    Co-authored-by: JP <jonathan.percival@smilecdr.com>
    Co-authored-by: Jonathan Percival <jonathan.i.percival@gmail.com>

commit 4e7500e
Author: mdnazmulkarim <nazmul.karim@smilecdr.com>
Date:   Mon Oct 2 20:40:14 2023 -0600

    repository search by id (#353)

    * repository search by id

    * apply formatting

    * separate InMemory test

    * remove redundancy

    * search by id update

    * search by id update test

    * search by id update test script

    * reformat

    * Fix repository and tests

    * Fixes for repo api

    ---------

    Co-authored-by: Jonathan Percival <jonathan.i.percival@gmail.com>
    Co-authored-by: JP <jonathan.percival@smilecdr.com>

commit a9af518
Author: mdnazmulkarim <nazmul.karim@smilecdr.com>
Date:   Mon Oct 2 10:42:24 2023 -0600

    add measure extension url publish pages (#349)

    * add measure extension url publish pages

    * apply formatting
JPercival added a commit that referenced this issue Nov 19, 2023
@JPercival @barhodes
Add unit test code coverage requirements (#348)
4c3052e 
* Experiment

* Codecov action

* Add jacoco to package profile

* Add ignored paths

* Fix test report uploads

* Squashed commit of the following:

commit af2db9a
Author: mdnazmulkarim <nazmul.karim@smilecdr.com>
Date:   Fri Oct 27 10:25:08 2023 -0600

    snapshot 3.0.0-PRE-10 (#371)

commit 0ff4f32
Author: JP <jonathan.percival@smilecdr.com>
Date:   Thu Oct 26 13:15:54 2023 -0600

    Update versions and fix build / test publication (#370)

commit b235356
Author: JP <jonathan.percival@smilecdr.com>
Date:   Fri Oct 20 10:42:06 2023 -0600

    Feature use new java extension (#364)

    * Swap to Java Platform Support extension for VS Code

    * Fix up pom

    * pom clean-up

    * Fix warnings

    * Fix formatting

    * Update java version and distribution

    * Add maven cache

    * Add implicit flag for benchmarks

commit 9790135
Author: Vitor Pamplona <vitor@vitorpamplona.com>
Date:   Mon Oct 16 15:35:08 2023 -0400

    Fixes crash on measure evaluate when subjectIds is null (#359)

    Fixes #358

commit 5b5414e
Author: Justin McKelvy <60718638+Capt-Mac@users.noreply.github.com>
Date:   Thu Oct 12 09:53:00 2023 -0600

    isolate getsubjects method in Measure Processor (#361)

    spotless apply

commit 0fe8e3a
Author: Jonathan Percival <jonathan.i.percival@gmail.com>
Date:   Thu Oct 5 14:36:08 2023 -0600

    Rev to PRE9 Snapshot

commit 4b799ca
Author: Jonathan Percival <jonathan.i.percival@gmail.com>
Date:   Thu Oct 5 13:28:25 2023 -0600

    --amend

commit d3f7b09
Author: Jonathan Percival <jonathan.i.percival@gmail.com>
Date:   Thu Oct 5 13:16:37 2023 -0600

    Rev to release version

commit 8057c70
Author: Justin McKelvy <60718638+Capt-Mac@users.noreply.github.com>
Date:   Wed Oct 4 10:32:11 2023 -0600

    Measure service subject reporttype bugs (#354)

    * fix reportType null bug, add subject & practitioner referenc to MR, practitionerGroup paramter, reporter param

    * add measureService tests for r4

    * spotless apply fixes

    * copy reportType setting from r4 to Dstu3 processor

    * revert defaulting logic for reportType, add check for null item in list for default reportType

    * remove commented out code, spotless apply edits

    ---------

    Co-authored-by: JP <jonathan.percival@smilecdr.com>

commit ad744bd
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Oct 4 10:27:14 2023 -0600

    Bump pillow from 9.4.0 to 10.0.1 in /docs/src/doc (#355)

    Bumps [pillow](https://github.com/python-pillow/Pillow) from 9.4.0 to 10.0.1.
    - [Release notes](https://github.com/python-pillow/Pillow/releases)
    - [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst)
    - [Commits](python-pillow/Pillow@9.4.0...10.0.1)

    ---
    updated-dependencies:
    - dependency-name: pillow
      dependency-type: direct:production
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 87434a4
Author: Jonathan Percival <jonathan.i.percival@gmail.com>
Date:   Mon Oct 2 22:15:46 2023 -0600

    More performance tweaks

commit 85e8933
Author: Jason Evans <jason.a.evans@gmail.com>
Date:   Mon Oct 2 21:50:01 2023 -0600

    KA issue 32 - optimize CQL for Lantana (#352)

    * Update GlycemicControlHypoglycemicInitialPopulation.cql

    * SupplementalDataElements changes

    * MATGlobalCommonFunctions R4 changes

    * MATGlobalCommonFunctions R3 changes

    * MATGlobalCommonFunctions QICore R4 changes

    * Fixes / optimizations

    * Revert non-CaseRepresentation content

    * Restore additional content

    ---------

    Co-authored-by: JP <jonathan.percival@smilecdr.com>
    Co-authored-by: Jonathan Percival <jonathan.i.percival@gmail.com>

commit 4e7500e
Author: mdnazmulkarim <nazmul.karim@smilecdr.com>
Date:   Mon Oct 2 20:40:14 2023 -0600

    repository search by id (#353)

    * repository search by id

    * apply formatting

    * separate InMemory test

    * remove redundancy

    * search by id update

    * search by id update test

    * search by id update test script

    * reformat

    * Fix repository and tests

    * Fixes for repo api

    ---------

    Co-authored-by: Jonathan Percival <jonathan.i.percival@gmail.com>
    Co-authored-by: JP <jonathan.percival@smilecdr.com>

commit a9af518
Author: mdnazmulkarim <nazmul.karim@smilecdr.com>
Date:   Mon Oct 2 10:42:24 2023 -0600

    add measure extension url publish pages (#349)

    * add measure extension url publish pages

    * apply formatting

* Revert "Squashed commit of the following:"

This reverts commit 5ef7c00.

* Fix paths

---------

Co-authored-by: Brenin Rhodes <brenin@alphora.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes crash on measure evaluate when subjectIds is null vitorpamplona/clinical-reasoning
1 participant
@vitorpamplona