Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detect EADDRINUSE on server start #1348

Merged
merged 21 commits into from
Dec 22, 2024
Merged

detect EADDRINUSE on server start #1348

merged 21 commits into from
Dec 22, 2024

Conversation

alex-Arc
Copy link
Collaborator

@alex-Arc alex-Arc commented Nov 28, 2024 •
edited
Loading

No description provided.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 28, 2024 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@alex-Arc alex-Arc marked this pull request as ready for review December 20, 2024 17:05
@alex-Arc alex-Arc requested a review from cpvalente December 20, 2024 18:21
cpvalente
cpvalente reviewed Dec 21, 2024
View reviewed changes
apps/electron/src/main.js Outdated Show resolved Hide resolved
apps/server/src/app.ts Outdated Show resolved Hide resolved
apps/server/src/app.ts Outdated Show resolved Hide resolved
apps/server/src/app.ts Outdated Show resolved Hide resolved
apps/server/src/app.ts Outdated Show resolved Hide resolved
apps/server/src/classes/Logger.ts Outdated Show resolved Hide resolved
apps/server/src/app.ts Outdated Show resolved Hide resolved
apps/server/src/app.ts Outdated Show resolved Hide resolved
apps/server/src/app.ts Outdated Show resolved Hide resolved
apps/server/src/app.ts Outdated Show resolved Hide resolved
alex-Arc and others added 9 commits December 21, 2024 15:04
@alex-Arc @cpvalente
Update comment
4bb4ee9 
Co-authored-by: Carlos Valente <34649812+cpvalente@users.noreply.github.com>
@alex-Arc @cpvalente
update comment
8c37335 
Co-authored-by: Carlos Valente <34649812+cpvalente@users.noreply.github.com>
@alex-Arc @cpvalente
update comment
95b70f0 
Co-authored-by: Carlos Valente <34649812+cpvalente@users.noreply.github.com>
@alex-Arc
rename to escalate
abf8bef
@alex-Arc
extract serverTryDesiredPort
86430ad
@alex-Arc
type check server.address()
c5324d8
@alex-Arc
request shutdown on unrecoverable escalateError
cd6e892
@alex-Arc
combine network utils
e3bfb0e
@alex-Arc
reject promise
6c167ef
@alex-Arc alex-Arc requested a review from cpvalente December 21, 2024 19:08
cpvalente
cpvalente reviewed Dec 21, 2024
View reviewed changes
Copy link
Owner

@cpvalente cpvalente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is OK, although I didnt test, did we have some pending tasks here?
Meanwhile I left some small cleanup comments for you, we should be able to merge after that

apps/electron/src/main.js Outdated Show resolved Hide resolved
apps/server/src/utils/network.ts Outdated Show resolved Hide resolved
apps/server/src/utils/network.ts Outdated Show resolved Hide resolved
apps/server/src/utils/network.ts Outdated Show resolved Hide resolved
@alex-Arc
Copy link
Collaborator Author

I think this is OK, although I didnt test, did we have some pending tasks here?

yeah it is difficult to test the electron <-> server interaction in dev, one more thing that could be nice to improve at some point

@alex-Arc alex-Arc requested a review from cpvalente December 22, 2024 14:48
@alex-Arc alex-Arc merged commit 29243e3 into master Dec 22, 2024
4 checks passed
@alex-Arc alex-Arc deleted the port-colision branch December 22, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpvalente cpvalente cpvalente approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alex-Arc @cpvalente