events with 0 duration dose not contribute to next day calculation

[alex-Arc]

No description provided.

[coderabbitai]

Walkthrough

Several modifications were made to improve the calculation of gaps over midnight and event durations in the rundown-service. This involved tracking the previousDuration parameter in the generate function and the checkIsNextDay utility. Additionally, a test case was added to ensure events with a duration of 0 do not cause the next day calculation erroneously.

Changes

File Path	Change Summary
apps/server/src/services/rundown-service/...	Modified the generate function to track previousDuration and utilize it in calculating gapOverMidnight. Added a test case to verify the correct duration calculation when events have a duration of 0.
packages/utils/src/date-utils/checkIsNextDay.ts	Updated the checkIsNextDay function to accept previousDuration and handle the condition when it is 0.

Sequence Diagram(s)

sequenceDiagram
    participant RundownService
    participant DateUtils

    RundownService->>DateUtils: checkIsNextDay(previousStart, timeStart, previousDuration)

    alt previousDuration is 0
        DateUtils-->>RundownService: return false
    else
        alt timeStart is after previousStart
            DateUtils-->>RundownService: return true
        else
            DateUtils-->>RundownService: return false
        end
    end

Loading

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[cpvalente]

Good stuff, we just clarify the test name and are good to merge

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between cbf3d56 and 27d0db3.

Files selected for processing (3)

• apps/server/src/services/rundown-service/tests/rundownCache.test.ts (1 hunks)
• apps/server/src/services/rundown-service/rundownCache.ts (3 hunks)
• packages/utils/src/date-utils/checkIsNextDay.ts (1 hunks)

Files skipped from review due to trivial changes (1)

• apps/server/src/services/rundown-service/tests/rundownCache.test.ts

Additional comments not posted (3)

packages/utils/src/date-utils/checkIsNextDay.ts (1)

11-12: Logic correctly updated to handle zero duration events.

The update to checkIsNextDay correctly implements the new logic to prevent next day transition when previousDuration is zero. This change aligns well with the PR's objective.

apps/server/src/services/rundown-service/rundownCache.ts (2)

90-90: Proper initialization of previousDuration.

The variable previousDuration is initialized to null, which is appropriate for its use in tracking the duration of previous events.

---

116-116: Correct use of previousDuration in event gap calculations.

The previousDuration variable is effectively utilized to assess event transitions over midnight, enhancing the accuracy of the day span calculation.

Also applies to: 139-139

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 27d0db3 and 137ab87.

Files selected for processing (1)

• apps/server/src/services/rundown-service/tests/rundownCache.test.ts (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• apps/server/src/services/rundown-service/tests/rundownCache.test.ts