fix: duplicate validation

[cpvalente]

Fixes an issue where we were validating the wrong parameter in the duplicate endpoint

In short: we sent a newFilename property but expected the existence of a filename

[coderabbitai]

Walkthrough

This update introduces a new validation function, validateNewFilenameBody, to ensure robust handling of newFilename fields in API requests. This function has been incorporated into a specific route of the database router. The function ensures the newFilename string is sanitized, meaning it checks for existence, trims whitespace, removes invalid characters, and guarantees the presence of a JSON extension. This improves the input validation process, enhancing the security and reliability of filename handling.

Changes

File Path	Change Summary
apps/server/src/api-data/db/db.router.ts	Replaced validateFilenameBody with validateNewFilenameBody in the router.post('/:filename/duplicate') endpoint.
apps/server/src/api-data/db/db.validation.ts	Introduced validateNewFilenameBody to validate existence, format, and sanitization of newFilename fields.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6c20cb5 and 57f47f2.

Files selected for processing (2)

• apps/server/src/api-data/db/db.router.ts (2 hunks)
• apps/server/src/api-data/db/db.validation.ts (1 hunks)

Additional comments not posted (3)

apps/server/src/api-data/db/db.router.ts (2)

21-21: Update import to reflect the new validator function.

The import statement has been correctly updated to include validateNewFilenameBody from db.validation.js, aligning with the PR's objective to fix the parameter validation issue.

---

35-35: Correctly integrated new validation logic in the duplicate endpoint.

The route for duplicating a project file now correctly uses validateNewFilenameBody for validating the newFilename parameter. This change is consistent with the PR's description and should ensure that the correct data is validated.

apps/server/src/api-data/db/db.validation.ts (1)

44-66: Comprehensive validation logic for newFilename.

The newly introduced validateNewFilenameBody function includes checks for existence, string type, trimming, sanitization, non-emptiness, and ensuring a JSON extension. The use of custom sanitizers and detailed error messages enhances security and user feedback. This addition aligns with the PR's goal to fix the parameter validation issue effectively.