Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a headless version of ontime #1051

Merged
merged 13 commits into from
Jun 14, 2024
Merged

add a headless version of ontime #1051

merged 13 commits into from
Jun 14, 2024

Conversation

jwetzell
Copy link
Collaborator

@jwetzell jwetzell commented Jun 5, 2024

  • files are stored in the same location as the electron version
  • currently bundles binaries for win/mac/linux and x64 architecture
  • github action to build binaries and attach to release

Copy link
Contributor

coderabbitai bot commented Jun 5, 2024

Important

Review skipped

Review was skipped due to path filters

Files ignored due to path filters (8)
  • .github/workflows/build_cli.yml is excluded by none and included by none
  • apps/cli/.eslintrc is excluded by none and included by none
  • apps/cli/.gitignore is excluded by none and included by none
  • apps/cli/.prettierrc is excluded by none and included by none
  • apps/cli/README.md is excluded by none and included by none
  • apps/cli/main.js is excluded by none and included by none
  • apps/cli/package.json is excluded by none and included by none
  • pnpm-lock.yaml is excluded by !pnpm-lock.yaml and included by none

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jwetzell jwetzell marked this pull request as draft June 11, 2024 20:23
@jwetzell jwetzell marked this pull request as ready for review June 12, 2024 15:07
@jwetzell jwetzell requested review from alex-Arc and cpvalente June 12, 2024 15:07
Copy link
Collaborator

@alex-Arc alex-Arc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I don't have much to add to this
But let me know if there is a test build you want me to run

@jwetzell
Copy link
Collaborator Author

@alex-Arc I did publish a test version to NPM so on a system with Node >= 18 you can run npx @getontime/cli@dev to test.

Copy link
Owner

@cpvalente cpvalente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, I left some questions but am happy to merge this whenever you are happy

@jwetzell jwetzell force-pushed the feat/ontime-headless branch from 94947d3 to b5e5c11 Compare June 14, 2024 01:06
@jwetzell jwetzell merged commit 1044dfa into master Jun 14, 2024
3 checks passed
@jwetzell jwetzell deleted the feat/ontime-headless branch June 14, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants