Skip to content

Commit

Permalink
Revert "chore: add comment to Start function to inform about possib…
Browse files Browse the repository at this point in the history
…le instability when called (go-ldap#499)"

This reverts commit f09ee91.
  • Loading branch information
cpuschma committed Apr 12, 2024
1 parent 2260012 commit 5abb12b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 12 deletions.
7 changes: 1 addition & 6 deletions conn.go
Original file line number Diff line number Diff line change
Expand Up @@ -265,12 +265,7 @@ func NewConn(conn net.Conn, isTLS bool) *Conn {
return l
}

// Start initialises goroutines to read replies and process messages.
//
// Deprecated: It is usually not necessary to call this function
// manually. It is public for compatibility reasons and may
// cause a race condition when processing messages.
// See: https://github.com/go-ldap/ldap/issues/356
// Start initializes goroutines to read responses and process messages
func (l *Conn) Start() {
go l.reader()
go l.processMessages()
Expand Down
7 changes: 1 addition & 6 deletions v3/conn.go
Original file line number Diff line number Diff line change
Expand Up @@ -265,12 +265,7 @@ func NewConn(conn net.Conn, isTLS bool) *Conn {
return l
}

// Start initialises goroutines to read replies and process messages.
//
// Deprecated: It is usually not necessary to call this function
// manually. It is public for compatibility reasons and may
// cause a race condition when processing messages.
// See: https://github.com/go-ldap/ldap/issues/356
// Start initializes goroutines to read responses and process messages
func (l *Conn) Start() {
go l.reader()
go l.processMessages()
Expand Down

0 comments on commit 5abb12b

Please sign in to comment.